Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include project description json at both external and internal coordinates. #1277

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

autonomousapps
Copy link
Owner

@autonomousapps autonomousapps merged commit 978172a into main Oct 2, 2024
1 check passed
@autonomousapps autonomousapps deleted the trobalik.included-build branch October 2, 2024 23:33
@jjohannes
Copy link
Collaborator

Thanks for the heads up. I guess if all tests pass, this change should not cause any problems. I vaguely remember that we already were at a point where the information was duplicated. Before the now commented-out code was added. And that that caused some issue. But other changes now probably compensate for that. Or my memory is wrong. I don't remember details.

If I should run into anythings suspicious, I'll let you know.

@autonomousapps
Copy link
Owner Author

If I should run into anythings suspicious, I'll let you know.

Thanks. I also vaguely recall some problems involving duplication, but all the tests pass so 🤷

This was done to resolve an issue on a build I have at work. It was the simplest solution. I'd still love to simplify how we handle Coordinates, which might be the proper long-term fix for a lot of idiosyncrasies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants